Can anyone give me some constructive criticism /advice on how I can make this coding neater, better, etc? | Sololearn: Learn to code for FREE!
New course! Every coder should learn Generative AI!
Try a free lesson
+ 1

Can anyone give me some constructive criticism /advice on how I can make this coding neater, better, etc?

Looking for some constructive criticism https://code.sololearn.com/cpB1WfW83GAI/?ref=app

5th Mar 2019, 2:39 AM
D. Booey 📜
D. Booey 📜 - avatar
5 Answers
+ 2
hey! i actually had a fun time with your code and ascii art(: I got a bit carried away with refactoring, but take a look and let me know if you have any questions and feel free to use whatever! https://code.sololearn.com/c1AH6J5jp71M/?ref=app
5th Mar 2019, 3:13 AM
Nathan Lewis
Nathan Lewis - avatar
+ 1
Go to the code I made in the comments and we’ll talk there!
5th Mar 2019, 3:22 AM
Nathan Lewis
Nathan Lewis - avatar
+ 1
Nice graphics! You may check my code to get some ideas. I have put comments for understanding. My goal was to create one variable for all dices and call them by index. The evaluation of the result is also acquired from a dictionary. https://code.sololearn.com/c0YpUrgIYvtk/?ref=app
5th Mar 2019, 6:44 AM
tamaslud
tamaslud - avatar
0
Thanks Nathan Lewis! That's exactly what I was trying to get out of my head... I knew I could have used a list some how, instead of that grossly, messy, "if", "elif", etc.. But I couldn't get any thing out.. I'd just finished a 9 straight hour construction shift, with lots of walking (up and down stairs).. So I was mentally (and physically) beat. I still can't make sense of what you did.. But, I know what you did... Did that make sense?
5th Mar 2019, 3:18 AM
D. Booey 📜
D. Booey 📜 - avatar
0
Hey Nathan Lewis, can you take a look at my code again. I remember what I was trying to do, and why I was having problems with the list. I updated my code and would love to see your take on it.
5th Mar 2019, 3:54 AM
D. Booey 📜
D. Booey 📜 - avatar