What has Possibly gone Wrong??

Question

Please see my code - What is Incorrect?? How?? Why??? for relevant details...
Please Help...

Edit:
I tried the solutions given to me by @Krishna Teja Yeluripati and @Luka , but , alas, they still didn't work in my code...
I am unable to understand the problem now as the range was 25-30
But the result was - 28:24:29:1:
Please Help!

Answer 1

Don't do upper-- as it's not needed. This works.

for (int i = 1; i <= 4; i++) {
no = low + (rand() % (upper - low));
cout << no << ":";
}

Answer 2

Thank You, Sir