I need some feedbacks... | Sololearn: Learn to code for FREE!
New course! Every coder should learn Generative AI!
Try a free lesson
+ 6

I need some feedbacks...

Can anybody tell me how they see my code displayed on their screens... I think to have some resolution issues... can anybody help me to fix that? (the <svg> should be at the center of the screen and the background color should be plain light yellow at the beginning) 😊 https://code.sololearn.com/WSEOeEUUh8O5/?ref=app

16th Apr 2018, 8:28 PM
marcopl
marcopl - avatar
10 Answers
+ 4
On my phone, your X/O are too big for the squares. The first line top and the squares are fine. The bottom of the bottom line is missing about the bottom quarter of the letter.
16th Apr 2018, 8:32 PM
John Wells
John Wells - avatar
+ 4
Personally, I'd use svg to draw X/O so the coordinate system is the same. I haven't gotten good results across various window sizes as yet with my programs.
16th Apr 2018, 8:43 PM
John Wells
John Wells - avatar
+ 3
ok, now it SHOULD be better (tell if i'm right ^^)
16th Apr 2018, 9:54 PM
marcopl
marcopl - avatar
+ 2
Do you know how to display a block properly on any screen (I'm not very good with CSS). I tried with @media, but I suppose that there should be another method...
16th Apr 2018, 8:38 PM
marcopl
marcopl - avatar
+ 2
Ole113 啊额 I haven't learnt jQuery yet 😓
16th Apr 2018, 8:43 PM
marcopl
marcopl - avatar
+ 2
It was fine for me.
16th Apr 2018, 10:17 PM
John Wells
John Wells - avatar
+ 1
Cool code when I add a x or o it's kinda a little to the upper left other than that its cool
16th Apr 2018, 8:31 PM
Ole113
Ole113 - avatar
+ 1
Personally I would have made the code with js and jQuery so sorry I don't know how to do it with css
16th Apr 2018, 8:40 PM
Ole113
Ole113 - avatar
+ 1
It's important you can do $("ID(#) OR CLASS(.)).hide(); and when you call it the element will be hidden
16th Apr 2018, 8:44 PM
Ole113
Ole113 - avatar
+ 1
It was good on my screen. Great job!!
17th Apr 2018, 8:28 AM
Israel Debrah
Israel Debrah - avatar