I want to count the number of vowels from multiple inputs from user's choice but my code ain't doing it

Question

https://code.sololearn.com/cn55m3UG5a6f/?ref=app

Answer 1

Your code don't have that way check..

for(int i = 0; i < s_word.length(); i = i + 1){
if(int i = 0; i < mylist.size(); i = i + 1){ // what is this? Is it loop but typo? You have i already declared in first loop..
You must have next condition for check vowel here.

count = count + 1;
}
}

Try like this:

for(int i = 0; i < s_word.length(); i = i + 1){
for(int j= 0; j < mylist.size(); j= j + 1){
if(s_word[i] == mylist[j] )
count = count + 1;
}
}

Before this, take list of character, not string of characters.. Otherwise comparing with character with string is invalid..

edit:

seems, unlike otherlanguages, if mylist is a list, then I think c++ not support index approach for list.
the c++ way is to use iterator for list
instead of
for(int j= 0; j < mylist.size(); j= j + 1){
use
for(auto j = mylist.begin(); j!=mylist.end(); j = j + 1){
or
for(string s : mylist)
{
..
}
check now.
hope it help.

Answer 2

Yes, like this getline(cin,variableName) instead of cin >> variableName

Answer 3

Okay, so you forgot to reset the count variable at the end. Try to run the code again.

Answer 4

Tsering thank you so much it is working perfectly now

Answer 5

Jayakrishna🇮🇳 I still get an error😭

Answer 6

First, you can't access list with index.
Second, the compiler is complaining about comparing int to long unsigned int. I've fixed the code.

https://code.sololearn.com/clFh6wTK292G/?ref=app

Answer 7

Tsering so you basically saying no one can solve this here?
It's impossible?

Answer 8

Did you run the code I posted?

Answer 9

Tsering yess I did run it,let's take I input a word "yes" instead of giving me the output 1 since there's only one vowel on word "yes" it give me output of 1,2,3,........ you infinity

Answer 10

That is because you have to give the input like this:
YourWordWithoutSpace
end

Answer 11

Tsering the word 'yes' is without space though

Answer 12

Make sure to enter 'end' in newline

Answer 13

Tsering so how can I fix it for the case of a sentence with spaces?
cause the task was to get a string from the user any type not just a word

Answer 14

Use getline() function

Answer 15

How?
You mean for asking for an input?

Answer 16

Tsering

Answer 17

Tsering I should just change that part on while loop only?

Answer 18

Yes

Answer 19

Tsering the user doesn't get a chance for an input if I do that the code just run prints out 0's

Answer 20

Check the code, i just updated it.