Is it too long ???

Question

https://code.sololearn.com/cDaRGYxz9DJ4/?ref=app

Answer 1

As long as it works, it shouldn't be too long.

Answer 2

You have a lot of duplicate code. Putting it in a function that is called in both places would make it easier to get running initially and maintain in the future. However, as Learnsolo stated working is more important than length.

Answer 3

@<Learnsolo> The longer the code, the more likely you will encounter instruction cache misses ;(

Answer 4

Too long? no; as long as it works - just like @<Learnsolo> said. refactoring the code, e.g. into function like @John Wells suggest help with ease of read, easier to maintain & reduce programming mistake; modern compilers will automatically refactor the code to optimise it's execution when it compiles your code.